request: fix update of request pickup location #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
approved these changes
Aug 17, 2020
iGormilhit
added
the
f: circulation
AoNoOokami
requested review from
zannkukai and
sebdeleze
and removed request for
Garfield-fr
zannkukai
approved these changes
Aug 19, 2020
* Fixes the change of request pickup location. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1675-update-request
branch
from
0579069
to
25198f6
Compare
lauren-d
approved these changes
Aug 19, 2020
lauren-d
reviewed
Aug 19, 2020
| @@ -120,12 +120,11 @@ export class LoanService { | |||
| * @param pickupLocationPid: pickup location pid to update | |||
| * @return item data | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
To resolve the bug reported.
Dependencies
My PR depends on:
How to test?
Try to change the pickup location of a request in item detailed view.
Code review check list